Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates to faq, language guide and minor edits #4556

Merged
merged 4 commits into from
Aug 14, 2017

Conversation

mister-ben
Copy link
Contributor

Some miscellaneous doc updates, including:

  • Updates for v6, e.g. plugin -> registerPlugin
  • Tweaked and expanded some FAQ and language guide content.
  • Some fussing over writing Video.js consistently when a proper noun

@mister-ben mister-ben changed the title Doc updates docs: updates to faq, language guide and minor edits Aug 9, 2017
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mister-ben!

@@ -205,47 +210,24 @@ See [the plugins guide][plugins] for more information on Video.js plugins.

### `sourceOrder`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm..., I'd have to double check but I think this option is removed completely due to middleware and now it's always per source.

@mister-ben
Copy link
Contributor Author

mister-ben commented Aug 10, 2017

TODO: tech.md needs a substantial re-write too because of sourceOrder

@gkatsev
Copy link
Member

gkatsev commented Aug 14, 2017

@mister-ben that's awesome. Thanks!

@gkatsev gkatsev merged commit 1f3375e into videojs:master Aug 14, 2017
atefBB pushed a commit to atefBB/video.js that referenced this pull request Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants