Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused var in version.js #4458

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Removed unused var in version.js #4458

merged 1 commit into from
Jul 4, 2017

Conversation

Xitalogy
Copy link

Description

Removed an unused var in build/version.js

Specific Changes proposed

Removed a single line of code

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@gkatsev
Copy link
Member

gkatsev commented Jun 29, 2017

Thanks @Aeoril, congrats on your first PR :)

@gkatsev
Copy link
Member

gkatsev commented Jul 4, 2017

The only failing test is not related to this PR.

@gkatsev gkatsev merged commit 6986dbb into videojs:master Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

@dmlap dmlap dmlap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xitalogy @gkatsev @dmlap