Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use passive event listeners for touchstart/touchmove (5.x) #4445

Merged
merged 3 commits into from
Jul 4, 2017

Conversation

mister-ben
Copy link
Contributor

Description

#4440 for 5.x
Not using passive event listeners now causes Chrome to log warnings to the console, and possibly has a performance impact

Specific Changes proposed

Where supported, use passive event listeners for touchmove and touchstart

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
  • Reviewed by Two Core Contributors

@mister-ben mister-ben added the 5.x label Jun 27, 2017
@gkatsev gkatsev merged commit 8599c8e into videojs:5.x Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants