Prevent dupe events on enabled ClickableComponents #4316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
approved these changes
May 8, 2017
|
I guess we should fix this in 5.x as well. @mister-ben would you be able to make a PR for that? I could do it otherwise. |
|
It's causing some tests in MenuButton and TextTracksControls to fail on 5.x, will need to dig into why. |
5 tasks
gkatsev
pushed a commit
that referenced
this pull request
May 15, 2017
Like #4316 for v6, this prevents multiple click handlers being added if an already enabled component is enabled. In the PR for six, ClickableComponent was tracking this.enabled_ but this is incompatible with v5 on a MenuButton which also changes the state of this.enabled_. Removes event handlers in enable() before adding them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent ClickableComponents re-adding event listeners each time
enabled()is calledFixes #4312
Specific Changes proposed
this.enabled_)enable()doesn't do anything if the component is enabled, so the event handlers are not re-addedRequirements Checklist