fix: techOrder names can be camelCased. #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/js/utils/to-title-case.js
Outdated
| @@ -21,3 +21,7 @@ function toTitleCase(string) { | |||
| } | |||
|
|
|||
| export default toTitleCase; | |||
|
|
|||
| export function titleCaseEquals(str1, str2) { | |||
There was a problem hiding this comment.
Yes. Also, we need some tests, probably.
|
should we update any other if checks to use the new titleCaseEquals function? |
|
@brandonocasey I think updates to current code should be done in another PR. |
|
@gkatsev OK |
brandonocasey
requested changes
Apr 12, 2017
| * Compares the TitleCase versions of the two strings for equality. | ||
| * | ||
| * @param {string} str1 | ||
| * The first string to compare |
There was a problem hiding this comment.
I think we want a newline between this param and the other one for consistency
| assert.ok(titleCaseEquals('foo', 'foo'), 'foo equals foo'); | ||
| assert.ok(titleCaseEquals('foo', 'Foo'), 'foo equals Foo'); | ||
| assert.ok(titleCaseEquals('Foo', 'foo'), 'Foo equals foo'); | ||
| assert.ok(titleCaseEquals('Foo', 'Foo'), 'Foo equals Foo'); |
There was a problem hiding this comment.
maybe some negative tests with notOK too? fOO & foo etc
brandonocasey
approved these changes
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new middleware work, the way that new sources were loaded was refactored. We also recently made techs and components work either TitleCased or camelcased. There was one comparison that didn't do the proper check and cause the tech to be reloaded, even if the two techs were the same.