Fix extra warn logs on already initialized player references #3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
requested changes
Dec 23, 2016
| 'logged the right message'); | ||
|
|
||
| log.warn = origWarnLog; | ||
| }); |
|
|
||
| const playerAgain = videojs('test_vid_id'); | ||
|
|
||
| assert.ok(player === playerAgain, 'did not create a second player from same tag'); |
There was a problem hiding this comment.
assert.equal would be preferred over ok and ===
|
|
||
| const playerAgainWithOptions = videojs('test_vid_id', { techOrder: ['techFaker'] }); | ||
|
|
||
| assert.ok(player === playerAgainWithOptions, |
| 'did not create a second player from same tag'); | ||
| assert.equal(warnLogs.length, 1, 'logged a warning'); | ||
| assert.equal(warnLogs[0], | ||
| 'Player "test_vid_id" is already initialised. ' + |
There was a problem hiding this comment.
you can keep this string on one line (for now)
|
|
||
| assert.ok(player, 'created player from tag'); | ||
| assert.ok(player.id() === 'test_vid_id'); | ||
| assert.ok(!warnLogs.length, 'no warn logs'); |
There was a problem hiding this comment.
maybe better to do an equals check with with length and 0?
| const player = videojs('test_vid_id', { techOrder: ['techFaker'] }); | ||
|
|
||
| assert.ok(player, 'created player from tag'); | ||
| assert.ok(player.id() === 'test_vid_id'); |
There was a problem hiding this comment.
assert.equal instead and don't forget a message.
|
Updated. Thanks for the review @gkatsev ! |
gkatsev
approved these changes
Dec 23, 2016
misteroneill
approved these changes
Dec 23, 2016
| @@ -45,6 +46,44 @@ QUnit.test('should return a video player instance', function(assert) { | |||
| player2.dispose(); | |||
| }); | |||
|
|
|||
| QUnit.test('should log about already initalized players if options already passed', | |||
There was a problem hiding this comment.
I think we'd ultimately want this test to use sinon.spy(log, 'warn') instead and to use the TestHelpers.makePlayer() function to create a mock player, but I don't think it should stop the PR from going in since there is time-sensitivity here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extra warnings were being logged when getting a reference to a player via videojs('player_id').
Requirements Checklist