Fix error in Fn.throttle that broke MouseTimeDisplay #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
added
needs: LGTM
gkatsev
approved these changes
Dec 5, 2016
| @@ -55,7 +55,7 @@ export const bind = function(context, fn, uid) { | |||
| * @return {Function} | |||
| */ | |||
| export const throttle = function(fn, wait) { | |||
| let last; | |||
| let last = Date.now(); | |||
gkatsev
added
confirmed
and removed
needs: LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a breakage in 5.14.0 of the MouseTimeDisplay UI that was caused by my work in 761b877
Specific Changes proposed
Fn.throttlefunction actually work.Requirements Checklist