Unify all Track and TrackList APIs #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
🎉 Yay, success! |
|
💯 |
brandonocasey
force-pushed
the
refactor/text-track-api
branch
from
aca2fc9 to
2156c9e
Compare
gkatsev
reviewed
Dec 29, 2016
| techOptions[props.getterName] = this[props.privateName]; | ||
| }); | ||
|
|
||
| techOptions = assign(techOptions, this.options_[techName.toLowerCase()]); |
There was a problem hiding this comment.
assign mutates, so, we should be able to keep techOptions as const.
|
@gkatsev made updates and removed all checks for |
gkatsev
approved these changes
Jan 3, 2017
brandonocasey
force-pushed
the
refactor/text-track-api
branch
from
c9d27f2 to
1ee9b5e
Compare
change addTrack_ to addTrack across the board
brandonocasey
force-pushed
the
refactor/text-track-api
branch
from
1ee9b5e to
bfc991e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR was already reviewed and approved here. This one will allow us to use browserstack to make sure that IE8-11 is not broken.
Requirements Checklist