-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we want to support three different ways to watch a ready
event in Player?
#3782
Comments
I think the only real candidate for removal would be the |
|
Good point. |
Ok with that in mind I guess it does make sense to keep all three of these unless we want to remove the ready function argument from |
... or get rid of |
How would that be possible @dmlap? |
I think we're not ready to remove ready :D |
Maybe we should abstract ready away from users and wrap our own methods in ready calls. We would just need to make sure that ready calls things in order. |
Whether we abstract it away, I don't think we want to remove it's functionality. |
Description
There are three ways to check for a player ready event, are we sure that we want to have three ways rather than just 1?
Pass a callback to the
videojs()
function as a third argument:Pass a callback to a player's
ready()
method:Listen for the player's
"ready"
event:The text was updated successfully, but these errors were encountered: