Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does the starttime/startTime option work? Do we want to keep it? #3781

Closed
brandonocasey opened this issue Nov 14, 2016 · 6 comments · Fixed by #3838
Closed

does the starttime/startTime option work? Do we want to keep it? #3781

brandonocasey opened this issue Nov 14, 2016 · 6 comments · Fixed by #3838

Comments

@brandonocasey
Copy link
Contributor

Description

Right now I see an option for start time referenced in a few places under two different names. I am thinking that it is a legacy option that probably does not work anymore. Do we want to make it work again, or fix the option?

Code Links:

@misteroneill
Copy link
Member

I vote to kill it. I don't think it's documented. And it's not a standard attribute.

@misteroneill
Copy link
Member

We discussed this morning and I believe the path forward will be to remove the startTime option being passed to the tech since it isn't used and we will deprecate the starttime option of the player in case someone is using it.

@brandonocasey
Copy link
Contributor Author

Found a place where startTime is used. https://github.com/videojs/video.js/blob/master/src/js/tech/flash.js#L49

@misteroneill
Copy link
Member

@brandonocasey
Copy link
Contributor Author

Do we want to keep startTime and deprecate starttime then?

@misteroneill
Copy link
Member

Yeah, I think that's probably what we need to do for now. It's mainly harmless.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants