docs(contributing.md): update CONTRIBUTING.md with latest info #3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mister-ben
reviewed
Oct 26, 2016
| @@ -30,92 +64,60 @@ Guidelines for bug reports: | |||
|
|
|||
| 3. Isolate the problem — **create a [reduced test case](https://css-tricks.com/reduced-test-cases/)** with a live example. You can possibly use [this JSBin example](http://jsbin.com/axedog/7/edit) as a starting point. | |||
There was a problem hiding this comment.
This jsbin has video.js 4.1
There was a problem hiding this comment.
oops, forgot to update to the newer one.
mister-ben
reviewed
Oct 26, 2016
| contrib feature start | ||
| ```sh | ||
| $ cp sandbox/index.html.example sandbox/index.html | ||
| $ open sandbox/index.html |
There was a problem hiding this comment.
Is it a good idea to encourage opening from file:// ?
There was a problem hiding this comment.
Maybe suggest running npm start and heading over to localhost:9999/sandbox/?
There was a problem hiding this comment.
Yes, though, that's literally the next section.
mister-ben
reviewed
Oct 26, 2016
| [GitHub Issues](https://github.com/videojs/video.js/issues) are used for all discussions around the codebase, including **bugs**, **features**, and other **enhancements**. | ||
|
|
||
| When filling out an issue, make sure to fill out the questions in the | ||
| ### Reporting a Bug | ||
|
|
||
| **A bug is a demonstrable problem** that is caused by the code in the repository. Good bug reports are extremely helpful. Thank You! |
There was a problem hiding this comment.
Maybe add a more explicit note that bugs in plugins should be filed against those plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.