fix: make sure that document.createElement exists before using #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you try and require videojs in an environment that doesn't implement `document.createElement` properly -- like in Node.js -- you could potentially get an error. This checks that `window.document && window.document.createElement` is available before calling `createElement`. We specifically check `window.document` so that `global` module won't cause issues with it's shimming of `document.createElement` in `global/document. Fixes #3665
ljharb
approved these changes
Oct 24, 2016
| if (typeof HTMLVideoElement === 'undefined') { | ||
| if (typeof HTMLVideoElement === 'undefined' && | ||
| window.document && | ||
| window.document.createElement) { |
There was a problem hiding this comment.
What about using document here instead of window.document? We're already importing it on line 8.
There was a problem hiding this comment.
As I mentioned in the description, we can't use document because global/document tries to shim the DOM API in node.
There was a problem hiding this comment.
Ignore me, then. Chalk it up to lack of sleep. 😆
misteroneill
approved these changes
Oct 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try and require videojs in an environment that doesn't implement
document.createElementproperly -- like in Node.js -- you could potentially get an error. This checks thatwindow.document && window.document.createElementis available before callingcreateElement.We specifically check
window.documentso thatglobalmodule won't cause issues with it's shimming ofdocument.createElementin `global/document.Fixes #3665