Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore timeupdate/loadedmetadata listeners for duration display #3682

Merged
merged 2 commits into from
Oct 17, 2016

Conversation

misteroneill
Copy link
Member

@misteroneill misteroneill commented Oct 12, 2016

This addresses a possible source of breakage introduced in #3349 where dependent applications could be using the removed events to manually force a duration display update.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors

@misteroneill misteroneill added patch This PR can be added to a patch release. needs: LGTM Needs one or more additional approvals labels Oct 12, 2016
@misteroneill misteroneill changed the base branch from master to stable October 12, 2016 19:35
@gkatsev
Copy link
Member

gkatsev commented Oct 13, 2016

LGTM. I'll get it merged some time tomorrow. Also, would be easier if you allow me to make changes to the PR (checkbox on the sidebar, I think).

@misteroneill misteroneill added confirmed and removed needs: LGTM Needs one or more additional approvals labels Oct 13, 2016
@misteroneill
Copy link
Member Author

@gkatsev The "Allow edits from maintainers" checkbox is checked. 😕

@gkatsev
Copy link
Member

gkatsev commented Oct 13, 2016

Ah, maybe there just isn't an indicator to let me know whether it's available or not.

@misteroneill misteroneill added this to the 5.12 milestone Oct 17, 2016
@gkatsev gkatsev merged commit be5979a into videojs:stable Oct 17, 2016
@gkatsev
Copy link
Member

gkatsev commented Oct 17, 2016

This is released as part of 5.11.8.
Getting it out as part of 5.12.x is being a bit trickier for various reasons.

@misteroneill misteroneill deleted the update-on-timeupdate branch October 18, 2016 13:42
gkatsev added a commit that referenced this pull request Oct 18, 2016
…#3682)

There was a potential breakage that was caused by #3349. This restores the timeupdate and loadedmetadata listeners in the duration display that were removed. As part of 6.0, they could be removed as durationchange should be the correct and only listener we need.
@gkatsev
Copy link
Member

gkatsev commented Oct 18, 2016

It's in master 44ec0e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants