-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better build system for tests #3543
Comments
So we just want to be able to run the tests via karma and in the browser. I think we should do something more like what the generator does and have karma use the es5 bundle, and the browser also use that same bundle |
@brandonocasey if I'm reading it right, it still gets browserified separately and doesn't actually use the es5 code. |
I don't know what the specific downsides are but moving tests next to their source files seems convenient, and we did talk about trying to componentize/modularize things more in the source at one point. That might have been more about putting the CSS next to the source files, but similar concept. Feels like something you get 90% of the way through and then realize all the downsides. :) |
Yeah, very similar. If there isn't objection about this, I can put together a PoC for this, though, this one probably shouldn't hold back the release. |
I don't think we want to go down this route anymore. |
As part of #3445, the normal files are compiled using babel into an
es5/
folder and then browserified into thedist/
folder for users who aren't using browserify directly.However, the way the tests are build right now is that they're built separately via browserify with babelify through a karma plugin.
Probably, we'd want to apply a similar build step to the tests as we did for the source files. It gets slightly tricky because the test files require into
src/
directly rather than thees5/
folder. One potential solution is to move the test files to be siblings of the normal source files, so, then, they can just require the sibling file and the build is easy. @videojs/core-committers thoughts on this change to the test files?But as part of this, we'd want to investigate if we can keep the test build system similar to the src files.
The text was updated successfully, but these errors were encountered: