Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework inclusion of vtt.js #3491

Closed
gkatsev opened this issue Aug 3, 2016 · 3 comments
Closed

Rework inclusion of vtt.js #3491

gkatsev opened this issue Aug 3, 2016 · 3 comments

Comments

@gkatsev
Copy link
Member

gkatsev commented Aug 3, 2016

Description

We currently include vttjs by concatenating it to the release file. We also allow it to be included via a url in the novtt alternative build.
With the new build system coming from #3445 we probably want to include it another way that works with bundlers properly while still maintaining the ability to produce the novtt build.

@gkatsev gkatsev added this to the 3.12 build-improvements milestone Aug 3, 2016
@gkatsev
Copy link
Member Author

gkatsev commented Aug 12, 2016

So, I think what we want to have happen that we require vttjs directly but then in the dist builds, specifically, the novtt builds, it should be removed to use the asynchronous loading mechanism.

@brandonocasey
Copy link
Contributor

perhaps by using the envify and unreachable-branch-transform browserify transforms

@gkatsev
Copy link
Member Author

gkatsev commented Feb 16, 2017

Fixed.

@gkatsev gkatsev closed this as completed Feb 16, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants