Suppress Infinity duration on Android Chrome before playback #3476
Conversation
| } | ||
| }; | ||
| this.on(this.player_, 'timeupdate', checkProgress); | ||
| return 0; |
There was a problem hiding this comment.
I believe duration should be NaN when the true value is unknown.
|
Would you mind adding a unit test for this? |
| if (this.el_.duration === Infinity && | ||
| browser.IS_ANDROID && browser.IS_CHROME) { | ||
| if (this.el_.currentTime === 0) { | ||
| let checkProgress = () => { |
There was a problem hiding this comment.
The newly released version of videojs-standard will complain about the use of let for names that are never reassigned (const is preferred).
|
@misteroneill re the question I see on email notifications but not showing up here on why I've used |
| return NaN; | ||
| } | ||
| } | ||
| return this.el_.duration || NaN; |
There was a problem hiding this comment.
do the time components handle NaN correctly?
There was a problem hiding this comment.
They behave correctly and formatTime deals with it and Infinity.
|
LGTM. Needs a rebase against master. Would you be able to do it? Otherwise, I can take care of it as part of the merge. |
gkatsev
added
confirmed
minor
mister-ben
force-pushed
the
android-duration
branch
from
bcf0451 to
1cae6df
Compare
|
This needs to be rebased against master. |
mister-ben
force-pushed
the
android-duration
branch
from
1cae6df to
1f535f2
Compare
|
@gkatsev Looks like this branch has no conflicts with base branch, what needs to happen next? |
|
@gkatsev , @mister-ben What needs to happen next here ? |
|
It's ready to go and will be pulled into the 5.13 release. |
|
Awesome |
Description
Re issue #3079 and the discussion in #3083. Android Chrome returns
Infinityfor VOD HLS until after playback has started. This causes issues such as an unwanted flash of the live display control.Specific Changes proposed
HTML5 tech will return
NaNinstead ofInfinityif playback has not started. Fires adurationupdateevent once the reported duration can be believed if the duration is stillInfinity, so controls can update.Requirements Checklist