-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoplay doesn't work when currentSrc
is set
#3071
Comments
@jamesgorrie Your fix works well in multiple browsers, I posted a PR above. |
That's really weird, I can reproduce it in the jsbin example but if I try to do it myself in the sandbox files, it works just fine in chrome 50. |
Ah, I figured out what the issue is. It's a Mixed Content issue. The jsbin page is running over https but it's trying to load an http video. For whatever reason it fails to load the first video but somehow succeeds for the second. |
Here's an updated example that seems to be working just fine: https://jsbin.com/vefuzohuma/edit?html,js,output |
@jamesgorrie @rbran100 hey, any of you have any thoughts about my comments and questions above? |
@gkatsev When I read this mixed content seemed like a likely culprit, I put it on my list to test and get back to and just have not gotten there yet. sorry to leave you hanging. |
Thanks for getting back to me. Let me know if you get any further with that. |
@rbran100 cool, it might still be worth pulling that PR in. If you update it with the latest code we can pull it in. |
I merged the PR anyway, hopefully, it'll make life easier. |
It appears, if a page is loaded, we then have a
currentSrc
set.This then doesn't run the
setSrc
function as thecurrent.src === this.el_.src
So either this PR should include:
Or the
setSrc
method should be updated.Here is an example where autoplay won't work when we have
currentSrc
set from the browser.The text was updated successfully, but these errors were encountered: