Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: layout of control bar is transformed when don't using flex layout #2864

Closed
oanhnn opened this issue Nov 26, 2015 · 6 comments
Closed

bug: layout of control bar is transformed when don't using flex layout #2864

oanhnn opened this issue Nov 26, 2015 · 6 comments

Comments

@oanhnn
Copy link

oanhnn commented Nov 26, 2015

On some browser not support flex layout, videojs allow fallback to using display:table-cell (add class vjs-no-flex to player).
But i see a problem using display:table-cell with button tag.
Why not using div tag instead button tag? I think it will resolved this problem.

@mmcc
Copy link
Member

mmcc commented Nov 28, 2015

A lot of debate went into whether or not to use buttons, but ultimately everyone agrees that's the right choice (#1932). That being said, I've tested this in browsers that don't support flexbox (particularly IE8) and not noticed any issues. What browsers are you seeing this in?

@oanhnn
Copy link
Author

oanhnn commented Nov 28, 2015

I used default browser of android 4.2

@gkatsev
Copy link
Member

gkatsev commented Nov 28, 2015

What manufacturer? Samsung? HTC? something else?
The default browsers are different depending on the manufacturer.

@oanhnn
Copy link
Author

oanhnn commented Nov 28, 2015

You can test with newest chrome on linux (feddora 23) with class vjs-no-flex. It have same problem. It have a large space area in right of button play toggle.

@mmcc
Copy link
Member

mmcc commented Dec 15, 2015

IIRC, just adding .vjs-no-flex isn't a great way to test since you end up getting more styling than a browser that actually didn't support flexbox features would have.

@gkatsev
Copy link
Member

gkatsev commented Jul 25, 2016

Closing this issue due to lack of activity. If it is still a problem and we get more information and a reduced test case, we will happily re-open the issue.

@gkatsev gkatsev closed this as completed Jul 25, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants