Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling mistake in function name causing error #2793

Closed
jawadsahil opened this issue Nov 9, 2015 · 5 comments
Closed

Spelling mistake in function name causing error #2793

jawadsahil opened this issue Nov 9, 2015 · 5 comments

Comments

@jawadsahil
Copy link

https://github.com/videojs/video.js/blob/master/src/css/components/_progress.scss

Line 105 has a typo:
background: ligthen($secondary-background-color, 25%);

correct the spelling of ligthen;
It should be
background: lighten($secondary-background-color, 25%);

Thanks

@gkatsev
Copy link
Member

gkatsev commented Nov 9, 2015

Heh, oops.
Care to submit a PR with the spelling corrections? Thanks

@jawadsahil
Copy link
Author

I am new to this Git thing.. and still not familiar how exactly these PR works.. but if anyone can tell me the steps?

@Soviut
Copy link
Contributor

Soviut commented Nov 12, 2015

@jawadsahil The normal way to do a pull request (PR) is:

  • Fork the repo (click the "fork" button up top) so you have your own version of it
  • git clone the repo to your local system
  • update the code
  • run unit tests where applicable (in your case, not necessary)
  • commit
  • push back up to your fork
  • click the "pull request" button on your repo in github

However, with something this simple, you can just:

  • find the file on github
  • click the "edit" button near the top
  • use the inline editor to make the change
  • submitting the change will create a new commit on a temporary fork and perform a PR

@gkatsev
Copy link
Member

gkatsev commented Nov 12, 2015

@Soviut thanks for those steps!

@Soviut
Copy link
Contributor

Soviut commented Nov 13, 2015

I can confirm that this issue occurs in the CodePen theme builder. http://codepen.io/heff/pen/EarCt

videojstypo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants