infinite loop for unprefixed use.

[jdalton]

I noticed in src/js/player.js that if fsApi.fullscreenchange is unprefixed, so fullscreenchange, then it will trigger an infinite loop.

Events.on(document, fsApi.fullscreenchange, Fn.bind(this, function documentFullscreenChange(e){
  this.isFullscreen(document[fsApi.fullscreenElement]);

  // If cancelling fullscreen, remove event listener.
  if (this.isFullscreen() === false) {
    Events.off(document, fsApi.fullscreenchange, documentFullscreenChange);
  }
  this.trigger('fullscreenchange'); // <-- ohh noo
}));

[heff]

Thanks for the report! The listener is on the document but the context of the documentFullscreenChange function should be the player, so I'm not totally following how this is causing the loop yet, unless the event is bubbling up to the document from the player. Looking into it more.

[jdalton]

Actually this is the issue. Do you have any info on the commit that resolved?

[heff]

Ah, yeah.
#2351
07f0483

So if you're using 5.0 (not an RC) I would expect this to be fixed.

[jdalton]

Rock! Is it tricky to induce bubbling? (curious if you're using a real event or fake one )

[heff]

Mostly fake events that are copied from real ones . Built off the JSNinja example years ago and improved along the way.

You can set event.bubbles = true and it will bubble up. That should work with native events that bubble automatically, though I'm starting to see some weird behavior with keyboard events.

[riking]

There are still pages in the wild hitting this bug, as per webcompat/web-bugs#2498 , such as mentioned in this comment. Would you consider releasing a hot-fix for the old versions on your CDN or working with the affected sites to update the library?