Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since 5.0.0-rc60: Pause/Play functionality on click doesn't work any more #2504

Closed
moay opened this issue Aug 24, 2015 · 5 comments
Closed
Assignees
Milestone

Comments

@moay
Copy link

moay commented Aug 24, 2015

Since the update to 5.0.0-rc60, I cannot play/pause the video by clicking somewhere on the video-element any more. Used to work, now it doesn't on chrome, firefox and safari on mac. The issue is independent of the used media format, fails on both mp4 and webm.

@forbesjo
Copy link
Contributor

This bug also affects touch devices, once the control bar fades away there's no way to bring it back.

@moay
Copy link
Author

moay commented Aug 24, 2015

Confirm on chrome mobile (Android Lollipop)

@heff heff added this to the v5.0.0 milestone Aug 24, 2015
@heff
Copy link
Member

heff commented Aug 24, 2015

Added to the 5.0 milestone. We need someone to dig and and find out what changed.

@gkatsev gkatsev self-assigned this Aug 24, 2015
@gkatsev
Copy link
Member

gkatsev commented Aug 24, 2015

This is because #2499 made usingNativeControls call addTechControlsListeners because there are some cases where it wouldn't get called otherwise. In some cases, addTechControlListeners would get called twice and so two handlers would get called which would cancel each other out.
Working on a fix. First, I'll make sure that addTechControlsListeners always removes the listeners before re-adding. Then, I'll see whether there's a way to simplify when addTechcontrolsListeners get added.

@gkatsev
Copy link
Member

gkatsev commented Aug 25, 2015

Fixed by #2511.

@gkatsev gkatsev closed this as completed Aug 25, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants