Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support videoTracks and audioTracks properties #1618

Closed
timgreenfield opened this issue Oct 29, 2014 · 3 comments
Closed

Support videoTracks and audioTracks properties #1618

timgreenfield opened this issue Oct 29, 2014 · 3 comments

Comments

@timgreenfield
Copy link

First, I love the way techs need to conform to the HTML5 video element spec to participate with video.js.

One suggestion I have however is to expose all properties found in the HTML spec through the main video.js object to avoid making developers call them through the tech object. For example, audioTracks is part of the video element spec, but to access it today you must call player.tech.audioTracks(). This is very minor but I thought I'd mention it since it could make it a little easier on developers by not requiring them to know which APIs are plumbed all the way to the top level and which are not.


Original Title: Plumb through all tech properties defined in HTML5 video element

@heff
Copy link
Member

heff commented Oct 29, 2014

Thanks Tim! We do try to discourage developers from accessing the tech directly, but that's obviously not possible if we don't support the needed property/method. We have a milestone for 100% Spec Coverage that I'll add this to, specifically for audio/video tracks.

There's a bit of a challenge around API properties that we can't also support easily through Flash, like playbackRate and audio/video tracks, but we need to find a better way to handle those cases, rather than just limiting what the html5 and other techs can provide.

If you'd be interested in putting together a pull request to add the tracks properties to the player API, please feel free. It hopefully shouldn't be too hard to follow the pattern of the existing API methods.

@heff heff added this to the 100% Spec Coverage milestone Oct 29, 2014
@heff heff changed the title Plumb through all tech properties defined in HTML5 video element Support videoTracks and audioTracks properties Oct 29, 2014
@chimilord
Copy link

Hello guys, exists some way to enable double audio for videos in dash.js and videojs?

In specific I want to use the getCurrentTrackFor function but I got this error:

Uncaught TypeError: Cannot read property 'getCurrentTrackFor' of undefined

Thanks!

@gkatsev
Copy link
Member

gkatsev commented Feb 24, 2016

We've started work for this. See #3137 and #3130.
I'm going to close this and ask people to follow along with #3137 for this if they want updates.

@gkatsev gkatsev closed this as completed Feb 24, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants