Skip to content

Commit

Permalink
fix(time-display): restore hidden label text for screen readers. (#5157)
Browse files Browse the repository at this point in the history
Restore hidden label text for screen readers that describes what the button control does. 

Renames the Duration Time language item to Duration.

Deprecate controlText_ property.

Fix a typo in translations-needed.md.

Add a space in the hidden label for live-display, so that it doesn't run together with the visible "LIVE" indication.

Fixes #5135
  • Loading branch information
OwenEdwards authored and gkatsev committed May 11, 2018
1 parent 9607712 commit baa6b56
Show file tree
Hide file tree
Showing 44 changed files with 109 additions and 69 deletions.
4 changes: 2 additions & 2 deletions docs/guides/languages.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Video.js uses a JSON object to describe a language, where the keys are English a
"Play": "Reproducción",
"Pause": "Pausa",
"Current Time": "Tiempo reproducido",
"Duration Time": "Duración total",
"Duration": "Duración total",
"Remaining Time": "Tiempo restante",
...
}
Expand Down Expand Up @@ -90,7 +90,7 @@ videojs.addLanguage('es', {
Play: 'Reproducción',
Pause: 'Pausa',
'Current Time': 'Tiempo reproducido',
'Duration Time': 'Duración total',
'Duration': 'Duración total',
'Remaining Time': 'Tiempo restante',
...
});
Expand Down
4 changes: 2 additions & 2 deletions docs/legacy-docs/guides/languages.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ <h2 id="creating-the-language-file">Creating the Language File</h2>
&quot;Play&quot;: &quot;Reproducción&quot;,
&quot;Pause&quot;: &quot;Pausa&quot;,
&quot;Current Time&quot;: &quot;Tiempo reproducido&quot;,
&quot;Duration Time&quot;: &quot;Duración total&quot;,
&quot;Duration&quot;: &quot;Duración total&quot;,
&quot;Remaining Time&quot;: &quot;Tiempo restante&quot;,
&quot;Stream Type&quot;: &quot;Tipo de secuencia&quot;,
&quot;LIVE&quot;: &quot;DIRECTO&quot;,
Expand Down Expand Up @@ -65,7 +65,7 @@ <h2 id="adding-languages-to-video-js">Adding Languages to Video.js</h2>
&quot;Play&quot;: &quot;Reproducción&quot;,
&quot;Pause&quot;: &quot;Pausa&quot;,
&quot;Current Time&quot;: &quot;Tiempo reproducido&quot;,
&quot;Duration Time&quot;: &quot;Duración total&quot;,
&quot;Duration&quot;: &quot;Duración total&quot;,
&quot;Remaining Time&quot;: &quot;Tiempo restante&quot;,
&quot;Stream Type&quot;: &quot;Tipo de secuencia&quot;,
&quot;LIVE&quot;: &quot;DIRECTO&quot;,
Expand Down
2 changes: 1 addition & 1 deletion docs/translations-needed.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ If you add or update a translation run `grunt check-translations` to update the

## Progress Bar Translations

The progress bar as a translation with a few token replacements.
The progress bar has a translation with a few token replacements.
They key is `progress bar timing: currentTime={1} duration={2}` and the default English value is `{1} of {2}`.
This default value is hardcoded as a default to the localize method in the SeekBar component.

Expand Down
2 changes: 1 addition & 1 deletion lang/ar.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "تشغيل",
"Pause": "إيقاف",
"Current Time": "الوقت الحالي",
"Duration Time": "مدة",
"Duration": "مدة",
"Remaining Time": "الوقت المتبقي",
"Stream Type": "نوع التيار",
"LIVE": "مباشر",
Expand Down
2 changes: 1 addition & 1 deletion lang/ba.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Pusti",
"Pause": "Pauza",
"Current Time": "Trenutno vrijeme",
"Duration Time": "Vrijeme trajanja",
"Duration": "Vrijeme trajanja",
"Remaining Time": "Preostalo vrijeme",
"Stream Type": "Način strimovanja",
"LIVE": "UŽIVO",
Expand Down
2 changes: 1 addition & 1 deletion lang/bg.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Възпроизвеждане",
"Pause": "Пауза",
"Current Time": "Текущо време",
"Duration Time": "Продължителност",
"Duration": "Продължителност",
"Remaining Time": "Оставащо време",
"Stream Type": "Тип на потока",
"LIVE": "НА ЖИВО",
Expand Down
2 changes: 1 addition & 1 deletion lang/ca.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Reproducció",
"Pause": "Pausa",
"Current Time": "Temps reproduït",
"Duration Time": "Durada total",
"Duration": "Durada total",
"Remaining Time": "Temps restant",
"Stream Type": "Tipus de seqüència",
"LIVE": "EN DIRECTE",
Expand Down
2 changes: 1 addition & 1 deletion lang/cs.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Přehrát",
"Pause": "Pauza",
"Current Time": "Aktuální čas",
"Duration Time": "Doba trvání",
"Duration": "Doba trvání",
"Remaining Time": "Zbývající čas",
"Stream Type": "Stream Type",
"LIVE": "ŽIVĚ",
Expand Down
2 changes: 1 addition & 1 deletion lang/da.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Afspil",
"Pause": "Pause",
"Current Time": "Aktuel tid",
"Duration Time": "Varighed",
"Duration": "Varighed",
"Remaining Time": "Resterende tid",
"Stream Type": "Stream-type",
"LIVE": "LIVE",
Expand Down
2 changes: 1 addition & 1 deletion lang/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"Pause": "Pause",
"Replay": "Erneut abspielen",
"Current Time": "Aktueller Zeitpunkt",
"Duration Time": "Dauer",
"Duration": "Dauer",
"Remaining Time": "Verbleibende Zeit",
"Stream Type": "Streamtyp",
"LIVE": "LIVE",
Expand Down
2 changes: 1 addition & 1 deletion lang/el.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Aναπαραγωγή",
"Pause": "Παύση",
"Current Time": "Τρέχων χρόνος",
"Duration Time": "Συνολικός χρόνος",
"Duration": "Συνολικός χρόνος",
"Remaining Time": "Υπολοιπόμενος χρόνος",
"Stream Type": "Τύπος ροής",
"LIVE": "ΖΩΝΤΑΝΑ",
Expand Down
2 changes: 1 addition & 1 deletion lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"Pause": "Pause",
"Replay": "Replay",
"Current Time": "Current Time",
"Duration Time": "Duration Time",
"Duration": "Duration",
"Remaining Time": "Remaining Time",
"Stream Type": "Stream Type",
"LIVE": "LIVE",
Expand Down
2 changes: 1 addition & 1 deletion lang/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"Play Video": "Reproducción Vídeo",
"Pause": "Pausa",
"Current Time": "Tiempo reproducido",
"Duration Time": "Duración total",
"Duration": "Duración total",
"Remaining Time": "Tiempo restante",
"Stream Type": "Tipo de secuencia",
"LIVE": "DIRECTO",
Expand Down
2 changes: 1 addition & 1 deletion lang/fa.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"Pause": "مکث",
"Replay": "بازپخش",
"Current Time": "زمان کنونی",
"Duration Time": "مدت زمان",
"Duration": "مدت زمان",
"Remaining Time": "زمان باقیمانده",
"Stream Type": "نوع استریم",
"LIVE": "زنده",
Expand Down
2 changes: 1 addition & 1 deletion lang/fi.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Toisto",
"Pause": "Tauko",
"Current Time": "Tämänhetkinen aika",
"Duration Time": "Kokonaisaika",
"Duration": "Kokonaisaika",
"Remaining Time": "Jäljellä oleva aika",
"Stream Type": "Lähetystyyppi",
"LIVE": "LIVE",
Expand Down
2 changes: 1 addition & 1 deletion lang/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"Pause": "Pause",
"Replay": "Revoir",
"Current Time": "Temps actuel",
"Duration Time": "Durée",
"Duration": "Durée",
"Remaining Time": "Temps restant",
"Stream Type": "Type de flux",
"LIVE": "EN DIRECT",
Expand Down
2 changes: 1 addition & 1 deletion lang/gl.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"Play Video": "Reprodución Vídeo",
"Pause": "Pausa",
"Current Time": "Tempo reproducido",
"Duration Time": "Duración total",
"Duration": "Duración total",
"Remaining Time": "Tempo restante",
"Stream Type": "Tipo de secuencia",
"LIVE": "DIRECTO",
Expand Down
2 changes: 1 addition & 1 deletion lang/he.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"Pause": "השהה",
"Replay": "נַגֵּן שוב",
"Current Time": "זמן נוכחי",
"Duration Time": "זמן כולל",
"Duration": "זמן כולל",
"Remaining Time": "זמן נותר",
"Stream Type": "סוג Stream",
"LIVE": "שידור חי",
Expand Down
2 changes: 1 addition & 1 deletion lang/hr.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Pusti",
"Pause": "Pauza",
"Current Time": "Trenutno vrijeme",
"Duration Time": "Vrijeme trajanja",
"Duration": "Vrijeme trajanja",
"Remaining Time": "Preostalo vrijeme",
"Stream Type": "Način strimovanja",
"LIVE": "UŽIVO",
Expand Down
2 changes: 1 addition & 1 deletion lang/hu.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Lejátszás",
"Pause": "Szünet",
"Current Time": "Aktuális időpont",
"Duration Time": "Hossz",
"Duration": "Hossz",
"Remaining Time": "Hátralévő idő",
"Stream Type": "Adatfolyam típusa",
"LIVE": "ÉLŐ",
Expand Down
2 changes: 1 addition & 1 deletion lang/it.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Play",
"Pause": "Pausa",
"Current Time": "Orario attuale",
"Duration Time": "Durata",
"Duration": "Durata",
"Remaining Time": "Tempo rimanente",
"Stream Type": "Tipo del Streaming",
"LIVE": "LIVE",
Expand Down
2 changes: 1 addition & 1 deletion lang/ja.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "再生",
"Pause": "一時停止",
"Current Time": "現在の時間",
"Duration Time": "長さ",
"Duration": "長さ",
"Remaining Time": "残りの時間",
"Stream Type": "ストリームの種類",
"LIVE": "ライブ",
Expand Down
2 changes: 1 addition & 1 deletion lang/ko.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "재생",
"Pause": "일시중지",
"Current Time": "현재 시간",
"Duration Time": "지정 기간",
"Duration": "지정 기간",
"Remaining Time": "남은 시간",
"Stream Type": "스트리밍 유형",
"LIVE": "라이브",
Expand Down
2 changes: 1 addition & 1 deletion lang/nb.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Spill",
"Pause": "Pause",
"Current Time": "Aktuell tid",
"Duration Time": "Varighet",
"Duration": "Varighet",
"Remaining Time": "Gjenstående tid",
"Stream Type": "Type strøm",
"LIVE": "DIREKTE",
Expand Down
2 changes: 1 addition & 1 deletion lang/nl.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"Pause": "Pauzeren",
"Replay": "Opnieuw afspelen",
"Current Time": "Huidige tijd",
"Duration Time": "Tijdsduur",
"Duration": "Tijdsduur",
"Remaining Time": "Resterende tijd",
"Stream Type": "Streamtype",
"LIVE": "LIVE",
Expand Down
2 changes: 1 addition & 1 deletion lang/nn.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Spel",
"Pause": "Pause",
"Current Time": "Aktuell tid",
"Duration Time": "Varigheit",
"Duration": "Varigheit",
"Remaining Time": "Tid attende",
"Stream Type": "Type straum",
"LIVE": "DIREKTE",
Expand Down
2 changes: 1 addition & 1 deletion lang/pl.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Odtwarzaj",
"Pause": "Pauza",
"Current Time": "Aktualny czas",
"Duration Time": "Czas trwania",
"Duration": "Czas trwania",
"Remaining Time": "Pozostały czas",
"Stream Type": "Typ strumienia",
"LIVE": "NA ŻYWO",
Expand Down
2 changes: 1 addition & 1 deletion lang/pt-BR.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Tocar",
"Pause": "Pausar",
"Current Time": "Tempo",
"Duration Time": "Duração",
"Duration": "Duração",
"Remaining Time": "Tempo Restante",
"Stream Type": "Tipo de Stream",
"LIVE": "AO VIVO",
Expand Down
2 changes: 1 addition & 1 deletion lang/pt-PT.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"Pause": "Parar",
"Replay": "Reiniciar",
"Current Time": "Tempo Atual",
"Duration Time": "Duração",
"Duration": "Duração",
"Remaining Time": "Tempo Restante",
"Stream Type": "Tipo de Stream",
"LIVE": "EM DIRETO",
Expand Down
2 changes: 1 addition & 1 deletion lang/ru.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"Pause": "Приостановить",
"Replay": "Воспроизвести снова",
"Current Time": "Текущее время",
"Duration Time": "Продолжительность",
"Duration": "Продолжительность",
"Remaining Time": "Оставшееся время",
"Stream Type": "Тип потока",
"LIVE": "ОНЛАЙН",
Expand Down
2 changes: 1 addition & 1 deletion lang/sk.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"Pause": "Pozastaviť",
"Replay": "Prehrať znova",
"Current Time": "Aktuálny čas",
"Duration Time": "Čas trvania",
"Duration": "Čas trvania",
"Remaining Time": "Zostávajúci čas",
"Stream Type": "Typ stopy",
"LIVE": "NAŽIVO",
Expand Down
2 changes: 1 addition & 1 deletion lang/sr.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Pusti",
"Pause": "Pauza",
"Current Time": "Trenutno vrijeme",
"Duration Time": "Vrijeme trajanja",
"Duration": "Vrijeme trajanja",
"Remaining Time": "Preostalo vrijeme",
"Stream Type": "Način strimovanja",
"LIVE": "UŽIVO",
Expand Down
2 changes: 1 addition & 1 deletion lang/sv.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Spela",
"Pause": "Pausa",
"Current Time": "Aktuell tid",
"Duration Time": "Total tid",
"Duration": "Total tid",
"Remaining Time": "Återstående tid",
"Stream Type": "Strömningstyp",
"LIVE": "LIVE",
Expand Down
2 changes: 1 addition & 1 deletion lang/tr.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"Pause": "Duraklat",
"Replay": "Yeniden Oynat",
"Current Time": "Süre",
"Duration Time": "Toplam Süre",
"Duration": "Toplam Süre",
"Remaining Time": "Kalan Süre",
"Stream Type": "Yayın Tipi",
"LIVE": "CANLI",
Expand Down
2 changes: 1 addition & 1 deletion lang/uk.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "Відтворити",
"Pause": "Призупинити",
"Current Time": "Поточний час",
"Duration Time": "Тривалість",
"Duration": "Тривалість",
"Remaining Time": "Час, що залишився",
"Stream Type": "Тип потоку",
"LIVE": "НАЖИВО",
Expand Down
2 changes: 1 addition & 1 deletion lang/vi.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"Pause": "Tạm dừng",
"Replay": "Phát lại",
"Current Time": "Thời gian hiện tại",
"Duration Time": "Độ dài",
"Duration": "Độ dài",
"Remaining Time": "Thời gian còn lại",
"Stream Type": "Kiểu Stream",
"LIVE": "TRỰC TIẾP",
Expand Down
2 changes: 1 addition & 1 deletion lang/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "播放",
"Pause": "暂停",
"Current Time": "当前时间",
"Duration Time": "时长",
"Duration": "时长",
"Remaining Time": "剩余时间",
"Stream Type": "媒体流类型",
"LIVE": "直播",
Expand Down
2 changes: 1 addition & 1 deletion lang/zh-TW.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Play": "播放",
"Pause": "暫停",
"Current Time": "目前時間",
"Duration Time": "總共時間",
"Duration": "總共時間",
"Remaining Time": "剩餘時間",
"Stream Type": "串流類型",
"LIVE": "直播",
Expand Down
Loading

0 comments on commit baa6b56

Please sign in to comment.