fix: player.src() should return empty string if no source is set (#4711)

player.src() returns undefined for a new player but it should return '' like player.currentSrc() does and as the video element itself does.
videojs · Nov 1, 2017 · 9acbcd8 · 9acbcd8
1 parent 9cf9800
commit 9acbcd8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/js/player.js b/src/js/player.js
@@ -2285,7 +2285,7 @@ class Player extends Component {
   src(source) {
     // getter usage
     if (typeof source === 'undefined') {
-      return this.cache_.src;
+      return this.cache_.src || '';
     }
     // filter out invalid sources and turn our source into
     // an array of source objects

diff --git a/test/unit/player.test.js b/test/unit/player.test.js
@@ -193,6 +193,7 @@ QUnit.test('should get current source from src set', function(assert) {
 
   // check for matching undefined src
   assert.deepEqual(player.currentSource(), {});
+  assert.equal(player.src(), '');
 
   player.src('http://google.com');