Skip to content

Commit

Permalink
chore(grunt): fix getting changelog by switching to npm-run (#3687)
Browse files Browse the repository at this point in the history
shelljs-nodecli is having trouble getting the conventional-changelog package because the package name and binary name are different.

Fixes #3683
  • Loading branch information
misteroneill authored and gkatsev committed Oct 18, 2016
1 parent e932061 commit 8845bd3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
7 changes: 5 additions & 2 deletions build/grunt.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {gruntCustomizer, gruntOptionsMaker} from './options-customizer.js';
import chg from 'chg';
import nodeCli from 'shelljs-nodecli';
import npmRun from 'npm-run';

module.exports = function(grunt) {
require('time-grunt')(grunt);
Expand Down Expand Up @@ -32,7 +32,10 @@ module.exports = function(grunt) {
release: {
tag_name: 'v'+ version.full,
name: version.full,
body: nodeCli.exec('conventional-changelog', '-p videojs', {silent: true}).output
body: npmRun.execSync('conventional-changelog -p videojs', {
silent: true,
encoding: 'utf8'
})
},
},
files: {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@
"karma-sinon": "^1.0.5",
"load-grunt-tasks": "^3.1.0",
"markdown-table": "^1.0.0",
"npm-run": "^4.1.0",
"proxyquireify": "^3.0.0",
"qunitjs": "^1.23.1",
"shelljs-nodecli": "^0.1.1",
"sinon": "^1.16.1",
"time-grunt": "^1.1.1",
"uglify-js": "~2.7.3",
Expand Down

0 comments on commit 8845bd3

Please sign in to comment.