perf: save ~10ms on player.src call (#6141)

Don't use a case-insensitive regex for getting the extname. Don't try to guess the type if we're provided with one.
videojs · Jul 29, 2019 · 2e495dd · 2e495dd
1 parent 2e69448
commit 2e495dd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/js/utils/filter-source.js b/src/js/utils/filter-source.js
@@ -56,10 +56,12 @@ const filterSource = function(src) {
  *        src Object with known type
  */
 function fixSource(src) {
-  const mimetype = getMimetype(src.src);
+  if (!src.type) {
+    const mimetype = getMimetype(src.src);
 
-  if (!src.type && mimetype) {
-    src.type = mimetype;
+    if (mimetype) {
+      src.type = mimetype;
+    }
   }
 
   return src;

diff --git a/src/js/utils/url.js b/src/js/utils/url.js
@@ -132,7 +132,7 @@ export const getAbsoluteURL = function(url) {
  */
 export const getFileExtension = function(path) {
   if (typeof path === 'string') {
-    const splitPathRe = /^(\/?)([\s\S]*?)((?:\.{1,2}|[^\/]+?)(\.([^\.\/\?]+)))(?:[\/]*|[\?].*)$/i;
+    const splitPathRe = /^(\/?)([\s\S]*?)((?:\.{1,2}|[^\/]+?)(\.([^\.\/\?]+)))(?:[\/]*|[\?].*)$/;
     const pathParts = splitPathRe.exec(path);
 
     if (pathParts) {