fix: Use segmentInfo.trackInfo to get segment information. #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
fix/playlist-update-trackinfo
branch
from
8b7b2b0
to
83f1305
Compare
Codecov Report
@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
+ Coverage 86.44% 86.45% +0.01%
==========================================
Files 39 39
Lines 9551 9562 +11
Branches 2200 2204 +4
==========================================
+ Hits 8256 8267 +11
Misses 1295 1295
Continue to review full report at Codecov.
|
gkatsev
reviewed
Jul 12, 2021
src/segment-loader.js
Outdated
Comment on lines
1921
to
1923
| // no segment to append any data for or | ||
| // we do not have information on this specific | ||
| // segment yet |
There was a problem hiding this comment.
is this comment no longer accurate?
There was a problem hiding this comment.
This was removed in error. I will bring it back.
35 tasks
gkatsev
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prevents an issue shown via the test that I added. Mainly that a playlist change that happens before we append data from a
pendingSegment_will cause resetthis.currentMediaInfo_to be null. Thus causinghandleData_'s call tohasEnoughInfoToAppend_to throw onthis.currentMediaInfo_.hasAudio