feat: Update minimumUpdatePeriod handling #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
previously approved these changes
Sep 10, 2020
gesinger
reviewed
Sep 10, 2020
src/dash-playlist-loader.js
Outdated
| @@ -766,10 +764,11 @@ export default class DashPlaylistLoader extends EventTarget { | |||
|
|
|||
| // Clear & reset timeout with new minimumUpdatePeriod | |||
There was a problem hiding this comment.
It may be worth creating a updateMinimumUpdatePeriodTimeout_() function to centralize the logic of the three uses (even can include the clearing) and add a comment around why we use the target duration when the minimumUpdatePeriod is 0.
There was a problem hiding this comment.
Yup makes sense. Done
gesinger
reviewed
Sep 14, 2020
| if (minimumUpdatePeriod >= 0) { | ||
| this.minimumUpdatePeriodTimeout_ = window.setTimeout(() => { | ||
| this.trigger('minimumUpdatePeriod'); | ||
| }, minimumUpdatePeriod || this.media().targetDuration * 1000); |
There was a problem hiding this comment.
We should add a comment here saying why the default is target duration.
| @@ -646,6 +650,16 @@ export default class DashPlaylistLoader extends EventTarget { | |||
| } | |||
| } | |||
|
|
|||
| updateMinimumUpdatePeriodTimeout_() { | |||
There was a problem hiding this comment.
It would also make sense to add the clearing of the old one here too.
gkatsev
approved these changes
Sep 23, 2020
gkatsev
pushed a commit
that referenced
this pull request
Sep 24, 2020
This fixes a bug caused by an oversight in #942. If the MPD@minimumUpdatePeriod is 0 in the first dynamic MPD we load, we should use the media's target duration as the MPD refresh interval, however we need to wait until a playlist has been selected before we can know DashPlaylistLoader.media().targetDuration, otherwise we get a TypeError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of a set of upcoming changes to add support for live DASH playback. Specifically, this PR differentiates the handling of 2 cases which were formerly conflated:
MPD@minimumUpdatePeriodattribute has a value of 0, indicating that the MPD has no validity after the moment it was retrieved.MPD@minimumUpdatePeriodattribute is absent, indicating the MPD has infinite validity and will never be updatedSpecific Changes proposed
mpd-parserto allow us to identify case 2updateMaster()checks if a manifest'sminimumUpdatePeriodvalue changes, and return the new manifest if so.targetDuration, per existingTODO'minimumUpdatePeriod'event as there is no need to refresh the manifest