docs: update docs for overrideNative #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forbesjo
changed the title
gkatsev
reviewed
Apr 5, 2018
| @@ -99,20 +104,32 @@ Drop by our slack channel (#playback) on the [Video.js slack][slack-link]. | |||
| Get a copy of [videojs-http-streaming](#installation) and include it in your page along with video.js: | |||
|
|
|||
| ```html | |||
| <video id=example-video width=600 height=300 class="video-js vjs-default-skin" controls> | |||
| <video-js id=vid1 width=600 height=300 class="vjs-default-skin" controls> | |||
There was a problem hiding this comment.
might be worth having a section why video-js, though, maybe just a FAQ about the late-init stuff in video.js instead?
There was a problem hiding this comment.
Yeah I'll add an explanation and also add player.src() as an alternate setup
forbesjo
changed the title
forbesjo
commented
Apr 9, 2018
README.md
Outdated
| ### Via MSE with the [overrideNative](#overridenative) option | ||
| - Chrome Android | ||
| - Edge | ||
| - Mac Safari |
There was a problem hiding this comment.
Mac Safari is not supported yet
OshinKaramian
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to clean up the
overrideNativeoptionSpecific Changes proposed
video-jselement, how to useoverrideNativeand prefer httpsRequirements Checklist