fix: wrap onwarn values in an object as expected by the playlist-loader #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## main #1428 +/- ##
=======================================
Coverage 85.98% 85.98%
=======================================
Files 42 42
Lines 10428 10428
Branches 2412 2412
=======================================
Hits 8967 8967
Misses 1461 1461
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Is there a way to get this merged without writing additional tests? The change is extremely simple, and there is no regression as this was untested behaviour before the change. |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
dzianis-dashkevich
pushed a commit
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey, apologies for not first opening an issue, but it's a very small fix.
When debugging an issue in one of my projects I noticed the debug log:
VIDEOJS: DEBUG: VHS: PlaylistLoader > m3u8-parser warn for [URL]: undefined.This is caused by PlaylistLoader#parseManifest_ expecting onwarn to be called with an object that has a message parameter. In manifest.js#parseManifest the onwarn method is sometimes called with a string. It's also called with a message object inside the m3u8 parser.
Specific Changes proposed
We could either change onwarn to always return a string, or return a message object from inside manifest.js#parseManifest.
In this fix I went with the latter as to not break any usage of parseManifest.
Please let me know if anything is unclear, I'll be happy to append the PR.
Requirements Checklist