Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): update dependencies to de-dupe m3u8-parser in the tree #1388

Merged
merged 3 commits into from
Mar 31, 2023

Conversation

misteroneill
Copy link
Member

@misteroneill misteroneill commented Mar 31, 2023

Description

Fixes #1353

Specific Changes proposed

  • Updates the version of Video.js installed in the package-lock.json to 8.x. This resolves issues stemming from having two different VHS dependency trees present.
  • Updates videojs-contrib-quality-levels dev-dep to 3.x.
  • Adds @babel/ci and @popperjs/core as dev-deps because they are required by other things in the dev-dep tree.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #1388 (3d1c760) into main (d258fae) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1388      +/-   ##
==========================================
+ Coverage   85.36%   85.37%   +0.01%     
==========================================
  Files          40       40              
  Lines        9953     9953              
  Branches     2307     2307              
==========================================
+ Hits         8496     8497       +1     
+ Misses       1457     1456       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@misteroneill misteroneill merged commit 369ee66 into main Mar 31, 2023
@misteroneill misteroneill deleted the deps branch March 31, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question - are not dependency components automatically included when importing the js file?
2 participants