feat: remove handleManifestRedirects and always use XHR.responseURL if available #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #1226 +/- ##
==========================================
- Coverage 86.31% 86.30% -0.01%
==========================================
Files 39 39
Lines 9796 9792 -4
Branches 2278 2276 -2
==========================================
- Hits 8455 8451 -4
Misses 1341 1341
Continue to review full report at Codecov.
|
35 tasks
gesinger
reviewed
Dec 15, 2021
| @@ -2497,7 +2484,7 @@ QUnit.test('refreshes the xml if there is a minimumUpdatePeriod', function(asser | |||
| this.clock.tick(4 * 1000); | |||
|
|
|||
| assert.equal(this.requests.length, 1, 'refreshed manifest'); | |||
| assert.equal(this.requests[0].uri, 'dash-live.mpd', 'refreshed manifest'); | |||
| assert.equal(this.requests[0].uri, window.location.href.split('/').slice(0, -1).join('/') + '/dash-live.mpd', 'refreshed manifest'); | |||
There was a problem hiding this comment.
Should we move this into a function for readability?
gesinger
approved these changes
Dec 15, 2021
gkatsev
added a commit
that referenced
this pull request
Dec 15, 2021
…f available (#1226) BREAKING CHANGE: remove handleManifestRedirects option. Now XHR.responseURL will always be used when available.
misteroneill
pushed a commit
that referenced
this pull request
May 2, 2022
…f available (#1226) BREAKING CHANGE: remove handleManifestRedirects option. Now XHR.responseURL will always be used when available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.