Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(experimentalBufferBasedABR): start ABR timer on main playlist load #1026

Merged
merged 2 commits into from
Dec 7, 2020
Merged

fix(experimentalBufferBasedABR): start ABR timer on main playlist load #1026

merged 2 commits into from
Dec 7, 2020

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Dec 7, 2020

Start the timer later, so we don't try to call simpleSelector without a playlist. However, we should add a null-check there just in case.

Fixes #1025

@gkatsev gkatsev added this to the 2.4 milestone Dec 7, 2020
@gkatsev gkatsev merged commit 27de9a5 into main Dec 7, 2020
@gkatsev gkatsev deleted the null-check-simple-selector branch December 7, 2020 20:11
@gkatsev gkatsev mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonocasey brandonocasey brandonocasey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.

experimentalBufferBasedABR HLS: type errors over slow connections
2 participants
@gkatsev @brandonocasey