-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Video.js v8 #317
Comments
It is the recommended way to create a plugin project, but we haven't had time to update it. We are planning to do so in the next month or so, though! |
Thanks for the confirmation @misteroneill. I thought as much, just wanted to make sure I don't wait in vain. |
@misteroneill - FWIW it looks I can build an es6 plugin by nicking @mr-ben's tip and changing the browserslist in package-json to: "browserslist": [
">0.2%",
"not dead",
"not op_mini all",
"not safari < 10",
"not chrome < 51",
"not android < 5",
"not ie < 12"
], |
This seems to be solved in v9.0.0 without extra gymnastics. Thank you. Probably for Video.js v7.x one should stick with v8.0.0 of the generator instead of fiddling with the version requirement in package.json? |
Is this generator still the recommended way for a plugin project? Are there plans to make it compatible with Video.js v8?
Currently it fails to build working plugins, see for instance phloxic/videojs-sprite-thumbnails#45
I strongly suspect it's because it creates es5 compatible builds, which, apart from breaking, does not make sense with Video.js v8.
The text was updated successfully, but these errors were encountered: