Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseStreamController always honor config.startPosition when attaching(recovering) #6297

Closed
kedanielwu opened this issue Mar 21, 2024 · 2 comments · Fixed by #6591
Closed
Labels
Bug Question Verify Fixed An unreleased bug fix has been merged and should be verified before closing.
Milestone

Comments

@kedanielwu
Copy link

What do you want to do with Hls.js?

In BaseStreamController, onMediaAttached callback always use config.startPosition to call startLoad(), regardless the playback status. Is this behaviour desired? I found it bit weried.

lets say I set startPosition to 90, and played for a while, then call the recoverMediaError() call will seek back to 90, shouldn't BaseStreamController.lastCurrentTime be used in this case?

What have you tried so far?

No response

@kedanielwu kedanielwu added Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. Question labels Mar 21, 2024
@robwalch
Copy link
Collaborator

Using config.startPosition on attached is a "feature". While you need to clear or change the value before re-attaching the player, I can agree that this should not be the behavior when using recoverMediaError().

@robwalch robwalch added Bug and removed Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. labels Mar 21, 2024
@robwalch robwalch added this to the 1.6.0 milestone Mar 21, 2024
@robwalch
Copy link
Collaborator

#6591 fixes this behavior for recoverMediaError().

You can try the branch build at https://feature-interstitials.hls-js-4zn.pages.dev/demo/

@robwalch robwalch added the Verify Fixed An unreleased bug fix has been merged and should be verified before closing. label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Question Verify Fixed An unreleased bug fix has been merged and should be verified before closing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants