Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I am going to upgrade something in new repo, and fix some bugs when using webpack #82

Open
hexray-newbee opened this issue Apr 20, 2017 · 3 comments

Comments

@hexray-newbee
Copy link
Contributor

hexray-newbee commented Apr 20, 2017

repo: https://github.com/hxl-dy/clappr-rtmp-plugin/tree/upgrade

upgrades:

  1. jshint -> eslint
  2. webpack1 -> webpack2

fix bugs:
following bugs will occur when I use webpack to package it to my project:

  1. cannot auto play
  2. play button won't change to pause when playing and no action occurs after clicking it
  3. double click video screen won't trigger full screen action
  4. volume control doesn't work

could i ask you for help when getting stuck? thank you!

@flavioribeiro
Copy link
Member

yep @hxl-dy feel free to reach me any time you get stuck, thanks for helping on the maintenance of this project

@hexray-newbee
Copy link
Contributor Author

repo: https://github.com/hxl-dy/clappr-rtmp-plugin/tree/webpack2

DONE:

  1. jshint -> eslint
  2. webpack1 -> webpack2

TODO:

  1. use uglify#harmony
  2. remove babel

FIXME:

  1. double click video screen won't trigger full screen action

@flavioribeiro
Copy link
Member

@hxl-dy I wonder if it makes sense to bring the modifications in your branch to this repository, are you still actively using this plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants