Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large project images break the project modal on small screens. #302

Closed
gthoma17 opened this issue Jul 2, 2021 · 1 comment · Fixed by #304
Closed

Large project images break the project modal on small screens. #302

gthoma17 opened this issue Jul 2, 2021 · 1 comment · Fixed by #304

Comments

@gthoma17
Copy link

gthoma17 commented Jul 2, 2021

Is your feature request related to a problem? Please describe.
When i open a project modal on my 13' Macbook screen, if the image is large enough it pushes the content (project text and carousel buttons) off the screen with no ability to scroll to it.

Describe the solution you'd like
I'd like to be able to scroll the entire project modal, not just the text content.

Describe alternatives you've considered
I'm adding custom CSS to my site to implement this, but it would be better if the theme did it automatically.

Additional context
Observe what happens in when I click to the third photo in the the photography project from the example site in this .mov:

introduction_doesnt_scroll_projects-trimmed.mov
@victoriadrake victoriadrake linked a pull request Jul 24, 2021 that will close this issue
@github-actions
Copy link

github-actions bot commented Aug 2, 2021

It looks like this has been idle a while, so I am marking it as stale. Remove the label or comment if this issue should remain open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant