Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade maven plugin jackson version to 2.17.2 #481

Closed
takanuva15 opened this issue Oct 3, 2024 · 2 comments
Closed

Upgrade maven plugin jackson version to 2.17.2 #481

takanuva15 opened this issue Oct 3, 2024 · 2 comments

Comments

@takanuva15
Copy link
Contributor

takanuva15 commented Oct 3, 2024

Hi, I'm working on upgrading our dependencies, and it seems the maven plugin imports jackson 2.14. Unfortunately, that doesn't seem to be compatible with jackson 2.17, which causes this error to trigger for me:

Caused by: org.apache.maven.plugin.PluginContainerException: An API incompatibility was encountered while executing com.github.victools:jsonschema-maven-plugin:4.36.0:generate: java.lang.NoSuchMethodError: 'void com.fasterxml.jackson.core.base.GeneratorBase.<init>(int, com.fasterxml.jackson.core.ObjectCodec, com.fasterxml.jackson.core.io.IOContext)'

Another poster on a different repo faced a similar issue and mentioned it's due to the conflict between jackson 2.14 and 2.17. I saw you merged a PR to update dependencies 4 days ago - is that the only thing we need to release to upgrade the jackson version and fix this issue?


EDIT: As a temporary patch, I force-upgraded the plugin dependency's jackson-core version to 2.17 and it seems to be working:

<plugin>
    <groupId>com.github.victools</groupId>
    <artifactId>jsonschema-maven-plugin</artifactId>
    <version>4.36.0</version>
    ...
    <dependencies>
        <dependency>
            <groupId>com.fasterxml.jackson.core</groupId>
            <artifactId>jackson-core</artifactId>
            <version>2.17.2</version>
        </dependency>
    </dependencies>
</plugin>
@CarstenWickner
Copy link
Member

#480 would not have solved this, but in #490 I did move the jackson version to 2.17.2.
That achieves the same as your workaround, yes.

@CarstenWickner CarstenWickner changed the title Upgrade maven plugin jackson version to 2.18? Upgrade maven plugin jackson version to 2.17.2 Nov 11, 2024
@CarstenWickner
Copy link
Member

Release v4.37.0 has just been published containing the dependency update mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants