From d29d0447e524ebf11a70de6df24d24b8e0bc1dee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20Cumplido?= Date: Wed, 10 Apr 2024 23:04:51 +0200 Subject: [PATCH] GH-41119: [Archery][Packaging][CI] Avoid using --progress flag on Docker on Windows on archery (#41120) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### Rationale for this change Windows wheels are currently failing due to the change on `ARCHERY_DEBUG=1` by default. This uses `--progress` on `docker build` which is not supported on Windows. ### What changes are included in this PR? Do not use `--progress` on the Windows builds. ### Are these changes tested? Yes on CI via archery. ### Are there any user-facing changes? No * GitHub Issue: #41119 Lead-authored-by: Raúl Cumplido Co-authored-by: Sutou Kouhei Signed-off-by: Sutou Kouhei --- dev/archery/archery/docker/core.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dev/archery/archery/docker/core.py b/dev/archery/archery/docker/core.py index 0b49111dd6944..7376bb0a3b72d 100644 --- a/dev/archery/archery/docker/core.py +++ b/dev/archery/archery/docker/core.py @@ -311,7 +311,7 @@ def _build(service, use_cache): self._execute_docker("buildx", "build", *args) elif self.config.using_docker: # better for caching - if self.config.debug: + if self.config.debug and os.name != "nt": args.append("--progress=plain") for k, v in service['build'].get('args', {}).items(): args.extend(['--build-arg', '{}={}'.format(k, v)]) @@ -324,7 +324,7 @@ def _build(service, use_cache): ]) self._execute_docker("build", *args) else: - if self.config.debug: + if self.config.debug and os.name != "nt": args.append("--progress=plain") self._execute_compose("build", *args, service['name'])