Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #868 #869

Merged
merged 1 commit into from
Oct 17, 2014
Merged

Fixes issue #868 #869

merged 1 commit into from
Oct 17, 2014

Conversation

japplegame
Copy link
Contributor

JsonStringSerializer.isSupportedValueType!(Nullable!T) equals true if T is numeric type.
This causes serializeImpl to call JsonStringSerializer.writeValue which fails If Nullable!T is empty.

@s-ludwig
Copy link
Member

Thanks, I should have checked the string serializer, since the normal one had the same issue.

s-ludwig added a commit that referenced this pull request Oct 17, 2014
@s-ludwig
Merge pull request #869 from japplegame/patch-1
4db9ca3 
Fix serializing Nullable!T with JsonStringSerializer with numeric T. Fixes #868.
@s-ludwig s-ludwig merged commit 4db9ca3 into vibe-d:master Oct 17, 2014
@japplegame japplegame deleted the patch-1 branch October 22, 2014 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@japplegame @s-ludwig