Fix access logging due to very nasty bug in Phobos' formatedWrite #808
Conversation
|
Looks like something went wrong when merging/rebasing the commits. Can you rebase against the official master branch and skip the commits that don't belong to the PR? |
|
I've had this issue with git before and had to copy the file over to the master repo.
|
|
here you go, should be good now. |
| ln.formattedWrite("%s %s %s", httpMethodString(req.method), req.requestURL, getHTTPVersionString(req.httpVersion)); | ||
| ln.put(httpMethodString(req.method)); | ||
| ln.put(req.requestURL); | ||
| ln.put(getHTTPVersionString(req.httpVersion)); |
There was a problem hiding this comment.
This is missing the spaces between the individual values.
|
Strange that the AA bug is still triggered, but I'll just ignore that, as it's unlikely to be related with this change. One small issue is that your changes seem to use spaces instead of tabs for indentation. BTW, depending on which editor you use, there may be an EditorConfig plugin available, which is very handy for these kinds of things. |
|
should be good now - thanks for the EditorConfig tip! |
|
OK, thanks! Merging. |
Fix access logging due to very nasty bug in Phobos' formatedWrite
https://issues.dlang.org/show_bug.cgi?id=11951