Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPServerRequest.fullURL crashes when host is missing #786

Closed
luismarques opened this issue Aug 21, 2014 · 2 comments
Closed

HTTPServerRequest.fullURL crashes when host is missing #786

luismarques opened this issue Aug 21, 2014 · 2 comments
Labels
bug

Comments

@luismarques
Copy link

The property HTTPServerRequest.fullURL does not work correctly with HTTP 1.0 (no Host header) or if you pass it an empty host header (e.g., wget --header="Host:"), causing the server to crash in the line url.host = url.host.split(":")[0];, due to url.host being null, the split result having 0 length, and therefore the [0] indexing generating a range violation error.
@s-ludwig s-ludwig added the bug label Aug 21, 2014
@s-ludwig
Copy link
Member

(not yet verified)

@s-ludwig
Copy link
Member

Successfully tested on Linux now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luismarques @s-ludwig