Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ubyte[] as a redis reply type #761

Merged
merged 1 commit into from
Aug 3, 2014

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Aug 3, 2014

ubyte arrays can be stored, but cannot be taken from a database directly.

ubyte[] arr = [0, 1, 2, 3, 4, 5];
db.set("key", arr); // ok

auto ret = db.get!(ubyte[])("key"); // Unsupported Redis reply type

@s-ludwig
Copy link
Member

s-ludwig commented Aug 3, 2014

Interesting, I made exactly the same fix yesterday, but didn't push it yet ;) I'll use yours and then start to convert RedisReply into a proper D range. The next planned direction is to reduce the need to memory allocations further by extending the API a bit.

s-ludwig added a commit that referenced this pull request Aug 3, 2014
Support ubyte[] as a redis reply type.
@s-ludwig s-ludwig merged commit 61f9568 into vibe-d:master Aug 3, 2014
@sinkuu
Copy link
Contributor Author

sinkuu commented Aug 3, 2014

Thanks.

Interesting, I made exactly the same fix yesterday,

Wow!

I'll use yours and then start to convert RedisReply into a proper D range. The next planned direction is to reduce the need to memory allocations further by extending the API a bit.

Awesome, I wondered why it isn't a Range.

@sinkuu sinkuu deleted the add_replytype branch August 3, 2014 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants