Fixed an exception raised with empty json requests. #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't the "Accept" header meant for that? It seems to be abuse of "Content-Type" to me, is this common practice? Anyway, that special case shouldn't cause any harm, so it's good to go. |
s-ludwig
added a commit
that referenced
this pull request
Dec 20, 2013
Fixed an exception raised with empty json requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty body requests with ‘Content-Type=application/json’ raise the exception “JSON string is empty.” when it tries to parse the result.
This is a huge issue with GET requests that use the content type to return either a html or json response.