Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 6455 -- Implemented incorrectly -- Origin not required. #389

Closed
schancel opened this issue Nov 17, 2013 · 1 comment
Closed

RFC 6455 -- Implemented incorrectly -- Origin not required. #389

schancel opened this issue Nov 17, 2013 · 1 comment

Comments

@schancel
Copy link

Line 84 of websocket.d should be changed:

    if( !(isUpgrade &&
          //pOrigin &&
          pUpgrade && *pUpgrade == "websocket" &&
          pKey &&
          pVersion && *pVersion == "13") )

The request MUST include a header field with the name |Origin|
[RFC6454] if the request is coming from a browser client. If
the connection is from a non-browser client, the request MAY
include this header field if the semantics of that client match
the use-case described here for browser clients. The value of
this header field is the ASCII serialization of origin of the
context in which the code establishing the connection is
running. See [RFC6454] for the details of how this header field
value is constructed.

@s-ludwig
Copy link
Member

Thanks. The code was written before the RFC was published, so there may actually be some more small differences left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants