-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement more caching & public cache api #2300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am currently very low on time, so I didn't had a chance to look into the RFCs yet, but I already left some first comments. Great work!
(accidentally pushed irrelevant changes I made to fix tests on my machines, broke on linux and windows) |
Allows to have runtime generated bodies with proper cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked a bit closer at https://tools.ietf.org/html/rfc7232#section-6 and it doesn't look like you follow it for all parts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Allows to have runtime generated bodies with proper cache
For example you can cache runtime diet files with this: (with my runtime diet PR on diet-ng)