-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change data serialization methods to auto ref in
#2275
Conversation
Also allow data to have disabled copy constructor.
Nice that this works now for all supported compilers, this should definitely work in some way. Unfortunately, requiring getters and |
Agreed would definitely break something. |
Thanks, this looks good now. The only thing I'm still wondering is how the correct
|
I've made the change, hopefully in the expected way :) Tests passed ok for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as I can tell. Thanks and sorry for losing track of this PR until now.
Also allow data to have disabled copy constructor.