-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix openssl cert peer validation #2121
Fix openssl cert peer validation #2121
Conversation
From https://linux.die.net/man/3/x509_name_get_index_by_nid So shouldn't the while loop in general be kept? |
Think so, too. AFAICT the mistake is that |
c3e0acc
to
32370d9
Compare
Fixed! |
Thanks! I'll merge it to master, too. |
This is quite important for GDPR compliance... are you able to do another 0.7.x release? |
Yes, I can do that. If you see any fixes in the change log for the 0.8.2 or 0.8.3 releases that look important, I could possibly merge those, too, to make the release more valuable. |
I will have a look and let you know! Thanks Sönke! :) |
Fix openssl cert peer validation
I guess this should be tagged as 0.8.4 or 0.8.3-1 then too? |
@s-ludwig I found the following commits that would be immediately valuable for us. important Fix support for outbound SSL w/ SSL1.1.x good to have Properly handle TLS disconnects in OpenSSLStream.leastSize. Use non-GC memory for MatchGraphBuilder. Use small integer types for MatchGraph(Builder) to reduce memory usage. good if compatible Thanks Sönke. |
This is for 0.7.32 and is important due to the imminent european GDPR deadline...
The same bug is also present in master.