preserve trailing back-slashes in NativePath #2079
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slash behavior originally introduced here 970a022#diff-3620332feace439ec637b023bc2e7a01R262, and apparently broken here 344fe34#diff-47d6be40e29a186df00d5f3bfad92671R36.
The weird usage of Path for URLs and file paths on Windows makes this difficult to handle properly (though
/
and\
usage should be mut-ex IIRC). No idea how much impact this breaking change would have. Any suggestion for a better migration path?