Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis connection pooling #199

Merged
merged 2 commits into from
Mar 30, 2013
Merged

Redis connection pooling #199

merged 2 commits into from
Mar 30, 2013

Conversation

jupenur
Copy link
Contributor

@jupenur jupenur commented Mar 23, 2013

I added connection pooling to the Redis client. Previously the client could only be used from a single fiber, with no way of moving it to another. That's now handled automatically by the connection pool.

@s-ludwig
Copy link
Member

Thanks for the improvements and sorry for the late reply. I just have two minor points:

  • Not sure from the way github displays the diff, but it looks like indentation uses spaces - should use tabs
  • It was already commented out before, but I think line 115 should indeed also check if m_conn is still connected

@jupenur
Copy link
Contributor Author

jupenur commented Mar 30, 2013

Uncommented. And yes, those are tabs.

@s-ludwig
Copy link
Member

Okay, great. I'll merge.

s-ludwig added a commit that referenced this pull request Mar 30, 2013
Redis connection pooling
@s-ludwig s-ludwig merged commit 808b372 into vibe-d:master Mar 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants